Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CBA4F200C6A for ; Wed, 19 Apr 2017 22:32:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CA3DF160B94; Wed, 19 Apr 2017 20:32:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 88960160B9C for ; Wed, 19 Apr 2017 22:32:51 +0200 (CEST) Received: (qmail 93376 invoked by uid 500); 19 Apr 2017 20:32:50 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 93281 invoked by uid 99); 19 Apr 2017 20:32:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 20:32:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5966EC28F9; Wed, 19 Apr 2017 20:32:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.451 X-Spam-Level: **** X-Spam-Status: No, score=4.451 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ZpiOSIniRLOS; Wed, 19 Apr 2017 20:32:48 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EB1D05FB2C; Wed, 19 Apr 2017 20:32:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9802BE0641; Wed, 19 Apr 2017 20:32:47 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5BB59C40522; Wed, 19 Apr 2017 20:32:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5246347230924745575==" MIME-Version: 1.0 Subject: Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir' From: Kirk Lund To: Jinmei Liao , Kirk Lund , Ken Howe Cc: geode , Jared Stewart Date: Wed, 19 Apr 2017 20:32:47 -0000 Message-ID: <20170419203247.32395.24228@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kirk Lund X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58518/ X-Sender: Kirk Lund References: <20170418215824.34543.80127@reviews-vm2.apache.org> In-Reply-To: <20170418215824.34543.80127@reviews-vm2.apache.org> Reply-To: Kirk Lund X-ReviewRequest-Repository: geode archived-at: Wed, 19 Apr 2017 20:32:53 -0000 --===============5246347230924745575== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58518/#review172401 ----------------------------------------------------------- It looks like LocatorServerStartupRule now always bounces VMs even if the test did not change user.dir. I thought you wanted it to bounce only if user.dir was altered? - Kirk Lund On April 18, 2017, 9:58 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58518/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 9:58 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir' > > - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to prevent corrupted cached values of `System.getProperty('user.dir')` that refer to a temporary folder which no longer exists. > > > Diffs > ----- > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java d47b3435a644f21ea28782c458afc6891577b1f4 > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java c5aaa743935bd0e5bff771213d111cb2f9b929cb > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java 34506c4fa803a1121c29d240ad7d7aa6a55dca99 > > > Diff: https://reviews.apache.org/r/58518/diff/1/ > > > Testing > ------- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > > --===============5246347230924745575==--