From dev-return-20208-apmail-geode-dev-archive=geode.apache.org@geode.apache.org Mon Apr 24 20:21:09 2017 Return-Path: X-Original-To: apmail-geode-dev-archive@minotaur.apache.org Delivered-To: apmail-geode-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17F26180D4 for ; Mon, 24 Apr 2017 20:21:09 +0000 (UTC) Received: (qmail 66616 invoked by uid 500); 24 Apr 2017 20:21:08 -0000 Delivered-To: apmail-geode-dev-archive@geode.apache.org Received: (qmail 66557 invoked by uid 500); 24 Apr 2017 20:21:08 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 66351 invoked by uid 99); 24 Apr 2017 20:21:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Apr 2017 20:21:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4F905189F89 for ; Mon, 24 Apr 2017 20:21:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ekEpKW3DJzJM for ; Mon, 24 Apr 2017 20:21:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CEC975FE4B for ; Mon, 24 Apr 2017 20:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 212E0E0D3C for ; Mon, 24 Apr 2017 20:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8617F21B5B for ; Mon, 24 Apr 2017 20:21:04 +0000 (UTC) Date: Mon, 24 Apr 2017 20:21:04 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: dev@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-2097) Offheap persistent heapLRU regions can run out of offheap memory during recovery MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GEODE-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981823#comment-15981823 ] ASF subversion and git services commented on GEODE-2097: -------------------------------------------------------- Commit 6eb9ff36dddeaaea01f624b453b4fa6d308b93f4 in geode's branch refs/heads/feature/GEODE-2632-6-1 from [~dschneider] [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=6eb9ff3 ] GEODE-2097: fix flaky test > Offheap persistent heapLRU regions can run out of offheap memory during recovery > -------------------------------------------------------------------------------- > > Key: GEODE-2097 > URL: https://issues.apache.org/jira/browse/GEODE-2097 > Project: Geode > Issue Type: Bug > Components: offheap > Reporter: Darrel Schneider > Assignee: Darrel Schneider > Fix For: 1.2.0 > > > When the data for a persistent region is being recovered from the disk store the lru limit is constantly checked. If the lru limit is exceeded then value recovery will cease. But for off-heap regions this lru limit should be checking how much off-heap memory has been allocated. > During recovery the amount of heap memory is being checked for an offheap regions. So we can end up recovering too many values to off-heap and running out of off-heap memory during recovery. > The code that causes this problem is: org.apache.geode.internal.cache.lru.HeapLRUCapacityController.createLRUHelper().new AbstractEnableLRU() {...}.mustEvict(LRUStatistics, Region, int) > During off-heap disk store recovery the Region parameter passed to this method is "null". This causes the following heap check to be done: > if (region == null) { > return resourceManager.getHeapMonitor().getState().isEviction(); > } -- This message was sent by Atlassian JIRA (v6.3.15#6346)