geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2745) The AsyncEventQueueImpl waitUntilFlushed method waits longer than it should for events to be flushed
Date Tue, 11 Apr 2017 20:48:41 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964942#comment-15964942
] 

ASF GitHub Bot commented on GEODE-2745:
---------------------------------------

GitHub user ladyVader opened a pull request:

    https://github.com/apache/geode/pull/448

    GEODE-2745: WaitUntilBucketRegionQueueFlushedCallable gets BucketRegi…

    
    GEODE-2745: waitUntilFlushed method waits longer than it should
    
    - Added getter in BucketRegionQueue for latestQueuedKey
    - WaitUntilBucketRegionQueueFlushedCallable constructor now gets/maintains the BucketRegionQueue.latestQueuedKey

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/geode feature/GEODE-2745

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #448
    
----
commit ba3b28adc48884bb5d697d307a28f4831f5d9301
Author: Lynn Hughes-Godfrey <lhughesgodfrey@pivotal.io>
Date:   2017-04-07T18:57:16Z

    GEODE-2745: WaitUntilBucketRegionQueueFlushedCallable gets BucketRegionQueue.latestQueuedKey
in constructor vs. setting when callable invoked.
    
    - Added getter in BucketRegionQueue for latestQueuedKey
    - WaitUntilBucketRegionQueueFlushedCallable constructor now gets/maintains the BucketRegionQueue.latestQueuedKey

----


> The AsyncEventQueueImpl waitUntilFlushed method waits longer than it should for events
to be flushed
> ----------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-2745
>                 URL: https://issues.apache.org/jira/browse/GEODE-2745
>             Project: Geode
>          Issue Type: Bug
>          Components: wan
>            Reporter: Barry Oglesby
>
> With the changes to waitUntilFlushed to process 10 buckets at a time, if events are happening
while waitUntilFlushed is in progress, then all the buckets after the first 10 will have processed
more than it should before returning.
> If the update rate is causing the queue to always contain 113000 events, and the events
are spread evenly across the buckets, each bucket will have 1000 events to wait for. The first
10 buckets will wait for their 1000 events. When those have been processed, the next 10 buckets
will wait for their 1000 events starting from that point, but they've already processed 1000
events. So, these buckets will actually wait for 2000 events to be processed before returning.
This pattern continues until all the buckets are done.
> The WaitUntilBucketRegionQueueFlushedCallable needs to track not only the BucketRegionQueue
but also the latestQueuedKey.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message