geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2730) Refactor ServerStarterRule and LocatorStarterRule
Date Wed, 12 Apr 2017 23:09:41 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966790#comment-15966790
] 

ASF GitHub Bot commented on GEODE-2730:
---------------------------------------

GitHub user jinmeiliao opened a pull request:

    https://github.com/apache/geode/pull/452

    GEODE-2730: refactor rules

    * consolidate the two sets of server/locator starter rules
    * do not allow member start up at test initialization time.
    * validate properties in @Before
    * use provider in the chained rules to get the appropriate ports in @Before

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jinmeiliao/geode rules

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/452.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #452
    
----
commit 330911c38b445d53aba49688488c2e014e457ebd
Author: Jinmei Liao <jiliao@pivotal.io>
Date:   2017-03-23T02:45:19Z

    GEODE-2730: refactor rules
    
    * consolidate the two sets of server/locator starter rules
    * do not allow member start up at test initialization time.
    * validate properties in @Before
    * use provider in the chained rules to get the appropriate ports in @Before

----


> Refactor ServerStarterRule and LocatorStarterRule
> -------------------------------------------------
>
>                 Key: GEODE-2730
>                 URL: https://issues.apache.org/jira/browse/GEODE-2730
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> Right now many tests that use ServerStarterRule and LocatorStarterRule are flaky due
to relying on default ports that intermittently cause BindExceptions when those ports are
in use. They also do not consistently use the @Rule lifecycle to manage starting the member,
but can optionally start members when the rule is instantiated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message