geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2684) org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
Date Wed, 05 Apr 2017 23:50:42 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958053#comment-15958053
] 

ASF subversion and git services commented on GEODE-2684:
--------------------------------------------------------

Commit 742c8f27ea45ec55445f1047fda3c54b86f89f94 in geode's branch refs/heads/develop from
[~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=742c8f2 ]

GEODE-2684 Connection & ConnectionTable cleanup

removed another old comment


> org.apache.geode.internal.tcp.Connection & ConnectionTable cleanup
> ------------------------------------------------------------------
>
>                 Key: GEODE-2684
>                 URL: https://issues.apache.org/jira/browse/GEODE-2684
>             Project: Geode
>          Issue Type: Task
>          Components: membership
>            Reporter: Bruce Schuchardt
>             Fix For: 1.2.0
>
>
> These classes contain a lot of commented-out code, poorly named methods and incorrect
calculations that need to be cleaned up.  For instance, Connection contains this:
> short aShort = -1;
> bytes[x] = (byte)(aShort & 0xff / 0x100);
> bytes[x+1] = (byte)(aShort & 0xff);
> which is incorrect and results in bytes[x] being zero when the intent is for it to be
255.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message