geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jhuynh1 <...@git.apache.org>
Subject [GitHub] geode pull request #479: GEODE-2828: AEQ created before the user region
Date Wed, 26 Apr 2017 21:22:26 GMT
Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/479#discussion_r113565230
  
    --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
---
    @@ -166,28 +166,28 @@ public void createIndex(final String indexName, String regionPath,
final Analyze
        * 
        * Public because this is called by the Xml parsing code
        */
    -  public void afterDataRegionCreated(final String indexName, final Analyzer analyzer,
    -      final String dataRegionPath, final Map<String, Analyzer> fieldAnalyzers,
    -      final String... fields) {
    -    LuceneIndexImpl index = createIndexRegions(indexName, dataRegionPath);
    -    index.setSearchableFields(fields);
    -    index.setAnalyzer(analyzer);
    -    index.setFieldAnalyzers(fieldAnalyzers);
    +  public void afterDataRegionCreated(LuceneIndexImpl index) {
         index.initialize();
         registerIndex(index);
         if (this.managementListener != null) {
           this.managementListener.afterIndexCreated(index);
         }
    +
    +  }
    +
    +  public LuceneIndexImpl beforeDataRegionCreated(final String indexName, final String
regionPath,
    +      RegionAttributes attributes, final Analyzer analyzer,
    +      final Map<String, Analyzer> fieldAnalyzers, String aeqId, final String...
fields) {
    +    LuceneIndexImpl index = createIndexRegions(indexName, regionPath);
    --- End diff --
    
    This wasn't introduced with this diff, but we probably want to rename this method.  I
don't think the method is creating any index regions.  I think it's just creating the index
object but none of the file/chunk or aeq region or buckets


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message