geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 58742: GEODE-2632: minor fixes from code review
Date Wed, 26 Apr 2017 17:51:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58742/#review173066
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On April 26, 2017, 5:17 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58742/
> -----------------------------------------------------------
> 
> (Updated April 26, 2017, 5:17 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
>     https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Apply fixes for issues from code review. Add TODO comments for larger issues.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java
69203117da71e80c753338b048e93de0f6859443 
>   geode-core/src/main/java/org/apache/geode/internal/cache/DistTXState.java 226ffa6cfa3636437011ed41ceadf69b08155a70

>   geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 74ec96c23076b88d009583a5cb778e147b829c09

>   geode-core/src/test/java/org/apache/geode/cache/query/internal/index/NewDeclarativeIndexCreationJUnitTest.java
e7f5c08cb3451e82dc1d3b23d777665b8fd05884 
> 
> 
> Diff: https://reviews.apache.org/r/58742/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message