geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markito <...@git.apache.org>
Subject [GitHub] geode-examples pull request #4: Updating and simplifying examples
Date Wed, 26 Apr 2017 00:09:17 GMT
Github user markito commented on a diff in the pull request:

    https://github.com/apache/geode-examples/pull/4#discussion_r113340583
  
    --- Diff: README.md ---
    @@ -17,29 +17,59 @@ limitations under the License.
     
     [<img src="https://geode.apache.org/img/apache_geode_logo.png" align="center"/>](http://geode.apache.org)
     
    -[![Build Status](https://travis-ci.org/apache/geode-examples.svg?branch=develop)](https://travis-ci.org/apache/geode-examples)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)

    +[![Build Status](https://travis-ci.org/apache/geode-examples.svg?branch=develop)](https://travis-ci.org/apache/geode-examples)
[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0)
     
     # Apache Geode examples
     
    -This is the home of Apache Geode examples that are bundled with the project. Contributions<sup>[2]</sup>
and corrections are welcome. Please talk to us about your suggestions at [dev@geode.apache.org](mailto:dev@geode.apache.org)
or submit a [pull request](https://github.com/apache/geode/pull/new/develop).
    +This is the home of Apache Geode examples that are bundled with the project.
    +Contributions<sup>[2]</sup> and corrections are welcome. Please talk to us
    +about your suggestions at [dev@geode.apache.org](mailto:dev@geode.apache.org)
    +or submit a [pull request](https://github.com/apache/geode/pull/new/develop).
     
    -## Example requirements
    +## Adding a new example
     
    -All examples:
    +Follow this approach to add a new example:
     
    -*  Need to be testable. Use unit tests, integration tests or whatever is applicable.
Tests will run through the project's CI.
    --- End diff --
    
    I do agree that the tests there seems enough, but by removing that text from the description
I thought we're removing the requirement.  If that's not the case, sounds good to me! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message