geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From upthewaterspout <...@git.apache.org>
Subject [GitHub] geode-examples issue #4: Updating and simplifying examples
Date Tue, 25 Apr 2017 23:07:17 GMT
Github user upthewaterspout commented on the issue:

    https://github.com/apache/geode-examples/pull/4
  
    Is lombok supposed to work in my IDE without installing a plugin? For me this code has
compile errors in intellij.
    
    I like the fact that you got rid of the shell scripts in favor of gfsh scripts, seems
like it makes the example a lot simpler looking!
    
    I think this might be going a little too far in terms of removing tests. There are definitely
things in the existing code that runAll is not testing since all you do is System.out.println.
Beyond that, I think showing how to write code using geode that has good unit tests might
be part of what makes a good example of geode?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message