geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
Date Fri, 21 Apr 2017 22:34:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/
-----------------------------------------------------------

(Updated April 21, 2017, 10:34 p.m.)


Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.


Changes
-------

This should be the final revision, precheckin runs green.


Repository: geode


Description
-------

GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'

- LocatorServerStarterRule will now always bounce the DUnit VMs in after() to prevent corrupted
cached values of `System.getProperty('user.dir')` that refer to a temporary folder which no
longer exists.


Diffs (updated)
-----

  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 1033b6c

  geode-core/src/test/java/org/apache/geode/management/JMXMBeanDUnitTest.java ebc3f17 
  geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
d47b343 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
c5aaa74 
  geode-core/src/test/java/org/apache/geode/test/dunit/VM.java 0b188ae 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/CleanupDUnitVMsRule.java PRE-CREATION

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
34506c4 


Diff: https://reviews.apache.org/r/58518/diff/3/

Changes: https://reviews.apache.org/r/58518/diff/2-3/


Testing
-------

Precheckin started (still running)


Thanks,

Jared Stewart


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message