geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nabarun nag <n...@pivotal.io>
Subject Re: Review Request 58550: AEQ regions being created before the user regions
Date Fri, 21 Apr 2017 08:08:47 GMT


> On April 21, 2017, 6:21 a.m., xiaojian zhou wrote:
> > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRegionListener.java
> > Lines 104 (patched)
> > <https://reviews.apache.org/r/58550/diff/1/?file=1695260#file1695260line104>
> >
> >     Why you did not specify "this.regionPath" in parameter? If so, your code will
be much simpler. Many code could be omitted. I will point them later.

the region path doesn't exist right now as this is the before region creation event listener.


- nabarun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58550/#review172584
-----------------------------------------------------------


On April 20, 2017, 2:03 a.m., nabarun nag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58550/
> -----------------------------------------------------------
> 
> (Updated April 20, 2017, 2:03 a.m.)
> 
> 
> Review request for geode, Jason Huynh and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Testing a new start up mechanism where the AEQ is created before the user region. Please
review and let us know if any modifications are needed, or if this is a viable solution
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
26bb488ed 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
0f5553343 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
fea484547 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
36f6720c3 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplFactory.java
e99f3d9db 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRawIndex.java
75ab5cab3 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneRegionListener.java
f4e2a79ef 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java
30952bfe2 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneEventListenerJUnitTest.java
79de29a09 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java
8e4c179a5 
> 
> 
> Diff: https://reviews.apache.org/r/58550/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> nabarun nag
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message