geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Galen O'Sullivan <gosulli...@pivotal.io>
Subject Re: Review Request 58544: GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl
Date Thu, 20 Apr 2017 15:52:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58544/#review172501
-----------------------------------------------------------


Ship it!




This is awesome. Using an interface rather than casting everything; deleting old comments
and commented code; making things more private. I don't know CQs or Lucene but it doesn't
look like you've changed anything in how they work. Excellent!

- Galen O'Sullivan


On April 19, 2017, 11:09 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58544/
> -----------------------------------------------------------
> 
> (Updated April 19, 2017, 11:09 p.m.)
> 
> 
> Review request for geode, Jason Huynh, Jinmei Liao, Jared Stewart, Ken Howe, and Dan
Smith.
> 
> 
> Bugs: GEODE-2632
>     https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2632 refactoring part 5
> 
> GEODE-2632: refactor code to use InternalCache instead of GemFireCacheImpl
> 
> * minor cleanup: delete dead-code and useless javadocs/comments, reduce scope of vars/methods/constants,
misc IDE warnings
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceProvider.java
cded9c319e9731f74fb6ec14a7f4a02187ae1603 
>   geode-core/src/main/java/org/apache/geode/cache/query/internal/cq/spi/CqServiceFactory.java
68ebbd54d4d2459ec8df27b15ace8c83942723f6 
>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ClientCQImpl.java 00a0aa5a9e7d8f770f2253e2c48dc6319d6864e3

>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqQueryImpl.java 22b4137c0d52bd84749b9617163b8723d1249ab6

>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceFactoryImpl.java
db90632437c80879b3ab213bbad34018809f1c31 
>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceImpl.java
f1ca8328ad9b9c67e70292093f117cc885d911b5 
>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceStatisticsImpl.java
ba71143cb271bd177b21e22e00d22a34f69c2834 
>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/CqServiceVsdStats.java
8435c4cea87401a6d29afc65d367d774dc3f4bf6 
>   geode-cq/src/main/java/org/apache/geode/cache/query/internal/cq/ServerCQImpl.java ec6e984e24b3dcdf40628bb6f510d0ff96a800f5

>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ.java
bcf98063c8ccf7c3d8ba44c9868b8921bb49a64b 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java
f333b4bdafdadad53060fe11ae9d98cc4f4593d4 
>   geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/GetDurableCQs.java
eac9ed3ad2da2afa92e1230d17b550301631307e 
>   geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsDUnitTest.java
7ace0e8e54bedf94622af5f011627a97c6316dd1 
>   geode-cq/src/test/java/org/apache/geode/cache/query/cq/dunit/CqStatsUsingPoolDUnitTest.java
d6068f1ecc88c076c3d1a8dbd3e3bc944766fbaa 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollector.java
66c4c0a298156926793f66eee1ac3efc85b27a14 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java
5313cedd48fa337ef9390a1659ed52dc9d9a0c77 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesCollectorJUnitTest.java
3bfebdf2e3b213b6e8b89075f7510f8dc7fbfb4d 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesFunctionCollectorJUnitTest.java
bf08877bf4cb1c8be07d69bd0bbdb529a2b2c340 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/TopEntriesJUnitTest.java
fcfebbcb9b46a7beedecc661c31c71836df34dc2 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
556311214371270259c024d565a6b4f0fa6a2146 
> 
> 
> Diff: https://reviews.apache.org/r/58544/diff/3/
> 
> 
> Testing
> -------
> 
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message