geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 58518: GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
Date Wed, 19 Apr 2017 20:14:32 GMT


> On April 19, 2017, 4:30 p.m., Jinmei Liao wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
> > Lines 82 (patched)
> > <https://reviews.apache.org/r/58518/diff/1/?file=1693891#file1693891line91>
> >
> >     this class also has a stopMember call, does that needs to call bounce() too?
> >     
> >     Is it possible that we have a cleanAndBounceVM function that would invoke the
cleanupVM first inside the vm, and then bounce it, so that the after will just invoke this
cleanAndBounce?

Sure, it seems like just adding `member.getVM().bounce();` to the end of stopMember() ought
to be enough?


- Jared


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58518/#review172356
-----------------------------------------------------------


On April 18, 2017, 9:58 p.m., Jared Stewart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58518/
> -----------------------------------------------------------
> 
> (Updated April 18, 2017, 9:58 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'
> 
> - LocatorServerStarterRule will now always bounce the DUnit VMs in after() to prevent
corrupted cached values of `System.getProperty('user.dir')` that refer to a temporary folder
which no longer exists.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DeployCommandRedeployDUnitTest.java
d47b3435a644f21ea28782c458afc6891577b1f4 
>   geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigTestBase.java
c5aaa743935bd0e5bff771213d111cb2f9b929cb 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58518/diff/1/
> 
> 
> Testing
> -------
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message