geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 58435: GEODE-2647: remove unnecessary client puts from ClientHealthStatsDUnitTest
Date Thu, 13 Apr 2017 22:50:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58435/#review171961
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On April 13, 2017, 10:15 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58435/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 10:15 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2647
>     https://issues.apache.org/jira/browse/GEODE-2647
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> This removes the puts from the clients which was unnecessary for the tests. By removing
the puts, the race condition caused by async puts and clears for the subscription enabled
test is gone.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/management/ClientHealthStatsDUnitTest.java
51425713175b3c8fe41f1064ac8a02178fd45e38 
> 
> 
> Diff: https://reviews.apache.org/r/58435/diff/1/
> 
> 
> Testing
> -------
> 
> ClientHealthStatsDUnitTest
> precheckin in progress
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message