geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Re: Review Request 58397: check off-heap limit during disk recovery
Date Wed, 12 Apr 2017 23:37:09 GMT


> On April 12, 2017, 2:50 p.m., Eric Shu wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java
> > Lines 294 (patched)
> > <https://reviews.apache.org/r/58397/diff/1/?file=1691066#file1691066line294>
> >
> >     lruStatistics or stats passed in?

Good catch. The intent here was to use the parameter; not the instance variable.
I think in most (perhaps all cases) they end up being the same thing.


- Darrel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58397/#review171801
-----------------------------------------------------------


On April 12, 2017, 11:55 a.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58397/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 11:55 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat.
> 
> 
> Bugs: GEODE-2097
>     https://issues.apache.org/jira/browse/GEODE-2097
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> During disk recovery, the code now checks the offheap LRU limit instead of the heap LRU
limit for offheap regions.
> A unit test has been added that without this fix would run out of offheap memory during
recovery.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/AbstractLRURegionMap.java
328ff35b940239bfbcf817d144d97f886506b33a 
>   geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java eaababaf6be6041c72156a338c69fa81f10db4c5

>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java d0aacc2d95fa38b1bc9faf68de795af5ef3d9090

>   geode-core/src/main/java/org/apache/geode/internal/cache/PlaceHolderDiskRegion.java
db01162aeeba8113c208565d683e71a41d0f6d00 
>   geode-core/src/main/java/org/apache/geode/internal/cache/ProxyRegionMap.java 92c7b6f8e90a3382e7ce00064581d69f9706fcd3

>   geode-core/src/main/java/org/apache/geode/internal/cache/lru/EnableLRU.java 6aaf8cc914c3b8c2e308446930bbd3215c9f58ca

>   geode-core/src/main/java/org/apache/geode/internal/cache/lru/HeapLRUCapacityController.java
5e86ce87b99fc4e8793461e881853c141fdfec1f 
>   geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUCapacityController.java
3596a07df407960c3558057ac33e92c89bd5ba22 
>   geode-core/src/main/java/org/apache/geode/internal/cache/lru/LRUMapCallbacks.java 27a4ec019ae3b5fd29a26ffc451d0d9feb75f903

>   geode-core/src/main/java/org/apache/geode/internal/cache/lru/MemLRUCapacityController.java
2c2e8ec1a805b7485e6e59858a12122fa8d88de1 
>   geode-core/src/test/java/org/apache/geode/internal/cache/lru/LRUClockJUnitTest.java
8095d5ac483be061199623a78b63618697e09d9d 
>   geode-core/src/test/java/org/apache/geode/internal/offheap/OffHeapLRURecoveryRegressionTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58397/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message