geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From galen-pivotal <...@git.apache.org>
Subject [GitHub] geode issue #404: Geode 2469
Date Tue, 11 Apr 2017 16:52:27 GMT
Github user galen-pivotal commented on the issue:

    https://github.com/apache/geode/pull/404
  
    @ggreen, I haven't had a lot of time to look at this lately. It looks like you checked
in some classes in the latest commit; we shouldn't have classes checked into the repository.
    
    I'm also having trouble reading your commit history; it's hard to tell what the merge
commits did, in particular d3b26424c20d723e563dd73b012323b7ff1f12f0 .
    
    If you have a Review Board account, it may be easier to read the changes as diffset, and
avoids some of the git merging-develop nastiness.
    
    It looks like there's a concurrency bug in the LockService, getting keys out of the WeakHashMap
isn't synchronized. I've got a WIP at my fork, branch `pr-404-concurrentLock` that addresses
this. I haven't had a chance to look at it in a while, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message