geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Darrel Schneider <dschnei...@pivotal.io>
Subject Review Request 58315: fix memory leak in transaction suspend/resume
Date Mon, 10 Apr 2017 18:59:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58315/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Eric Shu, and Lynn Gallinat.


Bugs: GEODE-2485
    https://issues.apache.org/jira/browse/GEODE-2485


Repository: geode


Description
-------

The CCPTimer is now purged for every 1000 cancels done. So we will now no longer have more
than 1000
cancelled tasks eating up memory.
Now uses internalSuspend in two places the previously used suspend. 
Since internalSuspend does not schedule a timer task these places will have no more issues
with leaking memory
and these code paths will perform better.

renamed resume(TxStateProxy) to internalResume for clarity.

internalResume no longer checks for TimerTask to cancel since internalSuspend does not add
one.
Instead the only code that checks for TimerTask is "resume".


Diffs
-----

  geode-core/src/main/java/org/apache/geode/cache/query/internal/DefaultQuery.java a7210916ed77e7e628a9d858fdad70a8276dbbe2

  geode-core/src/main/java/org/apache/geode/cache/query/internal/index/IndexManager.java 6cf9a3f1068c5c69bd755b82f120ca719a7cb7c8

  geode-core/src/main/java/org/apache/geode/internal/SystemTimer.java bddd06288161c2e6ba30b97c1c20915e0514438d

  geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java fa0257432aa149e70142e35d7432a5727ba035fd

  geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 15755175fc16609e0341d8c9e97039b5b83ce5d2

  geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 957038c8a173c7f0d1f5d3c7301673fd44add965

  geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataView.java
263df0f86b7c18504704506a1162cfebff394468 
  geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java 14fdf991b13661e5702b48480624ad1142a129b7

  geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java d577f3925c2087c204a9f43b46b26d421ed51be4

  geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxy.java c5e7cf6aef6134008f49716ff995a7e3772dd07e

  geode-core/src/main/java/org/apache/geode/internal/cache/TXStateProxyImpl.java a89cdc4a59c656cc3a2081c8aaa46d36b359c161

  geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java
d7b923c55bfca019956a2bffb613e310310ebedd 
  geode-core/src/main/java/org/apache/geode/pdx/internal/PeerTypeRegistration.java 653cafbdd4c8c93beafaa3dd9c97ff60750ce7ab

  geode-core/src/test/java/org/apache/geode/TXExpiryJUnitTest.java f55926ad7006375010fa37af2772d190a31a77aa

  geode-core/src/test/java/org/apache/geode/TXJUnitTest.java 5166a160ad71bc21d61c0c6199722abf113d7878

  geode-core/src/test/java/org/apache/geode/cache30/MultiVMRegionTestCase.java c51c9cc6da130b13480c68d93a6294f1c7bd4e3b

  geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java
3771fa87fa81bd752000f4291a9472f2b898e496 
  geode-core/src/test/java/org/apache/geode/internal/cache/GemFireCacheImplTest.java 288a3e1b9a5a17d1e4802626e17c7d74f308f468

  geode-core/src/test/java/org/apache/geode/internal/cache/RemoteTransactionDUnitTest.java
751bcd11fa7357f2d51be9d0bee732e3f9af395e 
  geode-core/src/test/java/org/apache/geode/internal/cache/TransactionsWithDeltaDUnitTest.java
c6aa376f868995b9335552abcded3fe62dd19bcc 
  geode-core/src/test/java/org/apache/geode/internal/cache/execute/MyTransactionFunction.java
9a0f3e66d2d05c889bd3e9020551fa4bad3f17f9 


Diff: https://reviews.apache.org/r/58315/diff/1/


Testing
-------

precheckin


Thanks,

Darrel Schneider


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message