geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 58155: GEODE-2653: fix a flaky test.
Date Thu, 06 Apr 2017 15:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/#review171212
-----------------------------------------------------------


Ship it!




Ship It!

- Udo Kohlmeyer


On April 5, 2017, 11:44 p.m., Galen O'Sullivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58155/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 11:44 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> And do some cleanup while I'm here:
>  * Change Mockito's `any` to `isA`.
>  * Replace some `Thread.sleep()` calls with Awaitility calls.
>  * Remove our `MethodExecuted` class -- this can be done with Mockito's `verify()`.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
05ab6f7e5 
> 
> 
> Diff: https://reviews.apache.org/r/58155/diff/2/
> 
> 
> Testing
> -------
> 
> Precheckin passed.
> 
> Ran the test suite in IntelliJ a few hundred times on my machine.
> 
> 
> Thanks,
> 
> Galen O'Sullivan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message