geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Galen O'Sullivan <gosulli...@pivotal.io>
Subject Re: Review Request 58155: GEODE-2653: fix a flaky test.
Date Wed, 05 Apr 2017 23:44:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58155/
-----------------------------------------------------------

(Updated April 5, 2017, 11:44 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.


Changes
-------

Remove a redundant assert.

I can't push this 'cause I'm not a committer.


Repository: geode


Description
-------

And do some cleanup while I'm here:
 * Change Mockito's `any` to `isA`.
 * Replace some `Thread.sleep()` calls with Awaitility calls.
 * Remove our `MethodExecuted` class -- this can be done with Mockito's `verify()`.


Diffs (updated)
-----

  geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java
05ab6f7e5 


Diff: https://reviews.apache.org/r/58155/diff/2/

Changes: https://reviews.apache.org/r/58155/diff/1-2/


Testing (updated)
-------

Precheckin passed.

Ran the test suite in IntelliJ a few hundred times on my machine.


Thanks,

Galen O'Sullivan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message