geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echobravopapa <...@git.apache.org>
Subject [GitHub] geode-native pull request #82: GEODE-2736: Fixed orphaned worker threads
Date Wed, 05 Apr 2017 15:11:10 GMT
Github user echobravopapa commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/82#discussion_r109942702
  
    --- Diff: src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
    @@ -303,6 +303,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest)
             LOGINFO("Executing the exception test it is expected to throw.");
             CacheableVectorPtr executeFunctionResult3 =
             funcExec->withArgs(arrList)->withFilter(filter)->execute("ThinClientRegionExceptionTest",
15)->getResult();
    +        FAIL("Failed to throw expected exception.");
    --- End diff --
    
    Perfect. @mhansonp may I ask you to please squash your commits as well...? TIA


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message