Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C2A27200C32 for ; Thu, 9 Mar 2017 17:18:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id BF8B7160B67; Thu, 9 Mar 2017 16:18:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0E02B160B64 for ; Thu, 9 Mar 2017 17:18:18 +0100 (CET) Received: (qmail 27771 invoked by uid 500); 9 Mar 2017 16:18:18 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 27760 invoked by uid 99); 9 Mar 2017 16:18:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 16:18:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C57A8DFDE6; Thu, 9 Mar 2017 16:18:17 +0000 (UTC) From: echobravopapa To: dev@geode.apache.org Reply-To: dev@geode.apache.org References: In-Reply-To: Subject: [GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri... Content-Type: text/plain Message-Id: <20170309161817.C57A8DFDE6@git1-us-west.apache.org> Date: Thu, 9 Mar 2017 16:18:17 +0000 (UTC) archived-at: Thu, 09 Mar 2017 16:18:19 -0000 Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r105204008 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void writeFullUTF(const char* value, uint32_t length = 0) { --- End diff -- ICKY, sounds like a separable refactoring chore... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---