Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2254200C2A for ; Wed, 1 Mar 2017 18:47:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D0C3B160B70; Wed, 1 Mar 2017 17:47:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 20986160B56 for ; Wed, 1 Mar 2017 18:47:25 +0100 (CET) Received: (qmail 9046 invoked by uid 500); 1 Mar 2017 17:47:25 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 9034 invoked by uid 99); 1 Mar 2017 17:47:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Mar 2017 17:47:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 82383C668A; Wed, 1 Mar 2017 17:47:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.45 X-Spam-Level: *** X-Spam-Status: No, score=3.45 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_MANYTO=0.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id V-dyLVwupi1W; Wed, 1 Mar 2017 17:47:23 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0194C5F23D; Wed, 1 Mar 2017 17:47:23 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DDEACE00D5; Wed, 1 Mar 2017 17:47:19 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C00DCC403EF; Wed, 1 Mar 2017 17:47:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1187151054738929385==" MIME-Version: 1.0 Subject: Re: Review Request 57171: GEODE-2461: remove json4s-ast_2.10 as explicit dependency From: Jared Stewart To: Jared Stewart , Udo Kohlmeyer , Anthony Baker , Mark Bretl , Jinmei Liao , Dan Smith Cc: Kirk Lund , geode Date: Wed, 01 Mar 2017 17:47:19 -0000 Message-ID: <20170301174719.39250.82252@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jared Stewart X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/57171/ X-Sender: Jared Stewart X-ReviewBoard-ShipIt: 1 References: <20170228221743.23893.28267@reviews.apache.org> In-Reply-To: <20170228221743.23893.28267@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jared Stewart X-ReviewRequest-Repository: geode archived-at: Wed, 01 Mar 2017 17:47:27 -0000 --===============1187151054738929385== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57171/#review167295 ----------------------------------------------------------- Ship it! Ship It! - Jared Stewart On Feb. 28, 2017, 10:17 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57171/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 10:17 p.m.) > > > Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, Mark Bretl, Udo Kohlmeyer, and Dan Smith. > > > Bugs: GEODE-2461 > https://issues.apache.org/jira/browse/GEODE-2461 > > > Repository: geode > > > Description > ------- > > Remove explicit dependency on json4s-ast_2.10. > > I couldn't find anything that actually uses json4s-ast_2.10, directly or transitively, so I've removed it completely. > > > Diffs > ----- > > geode-assembly/src/test/resources/expected_jars.txt a9a5a792a4e4aafb9b191cd3bf89d54fe559bc75 > geode-web-api/build.gradle 8b22bd8de174ddad47f4acbd0da75614a060da99 > gradle/dependency-versions.properties be828af14826ff63adee18717de063d87e2f1c6c > > > Diff: https://reviews.apache.org/r/57171/diff/1/ > > > Testing > ------- > > precheckin passed > > > Thanks, > > Kirk Lund > > --===============1187151054738929385==--