geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2595) Change LuceneService.createIndex to use a factory pattern
Date Fri, 10 Mar 2017 23:08:05 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905843#comment-15905843
] 

ASF GitHub Bot commented on GEODE-2595:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/421


> Change LuceneService.createIndex to use a factory pattern
> ---------------------------------------------------------
>
>                 Key: GEODE-2595
>                 URL: https://issues.apache.org/jira/browse/GEODE-2595
>             Project: Geode
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.2.0
>
>
> Before we remove the Experimental annotation from the LuceneService, we should change
createIndex to use a factory pattern rather than having a single method with parameters to
create the index. In other words, the method needs to change from:
> {code}
> luceneService.createIndex(region, index, ...)
> {code}
> to
> {code}
> luceneService.createIndexFactory()
>   .setXXX()
>   .setYYY()
>   .create()
> {code}
> This will allow us to add additional set methods in the future to configure other things
like the async event queue batch size, etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message