geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2578) Query string limited to 64 KiB
Date Tue, 07 Mar 2017 20:18:38 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900074#comment-15900074
] 

ASF GitHub Bot commented on GEODE-2578:
---------------------------------------

Github user echobravopapa commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/48#discussion_r104759602
  
    --- Diff: src/cppcache/src/TcrMessage.cpp ---
    @@ -756,8 +756,8 @@ void TcrMessage::writeRegionPart(const std::string& regionName)
{
       m_request->writeBytesOnly((int8_t*)regionName.c_str(), len);
     }
     
    -void TcrMessage::writeStringPart(const std::string& regionName) {
    -  m_request->writeFullUTF(regionName.c_str());
    +void TcrMessage::writeStringPart(const std::string& str) {
    --- End diff --
    
    here as well, much more intuitive var name


> Query string limited to 64 KiB
> ------------------------------
>
>                 Key: GEODE-2578
>                 URL: https://issues.apache.org/jira/browse/GEODE-2578
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Michael Dodge
>            Assignee: Michael Dodge
>
> The serialization of query strings uses a 16-bit unsigned integer to represent the length
of the query string. Query strings with more than 65535 characters are silently truncated.
Use of a 32-bit unsigned integer to represent the length would greatly increase the size of
query strings that may be used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message