geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-2513) Geode Native docs: rebrand to match open-source software
Date Thu, 16 Mar 2017 17:38:41 GMT

    [ https://issues.apache.org/jira/browse/GEODE-2513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928491#comment-15928491
] 

ASF GitHub Bot commented on GEODE-2513:
---------------------------------------

Github user PivotalSarge commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/59#discussion_r106483611
  
    --- Diff: docs/geode-native-docs/function-execution/handling-function-results.html.md.erb
---
    @@ -19,7 +19,7 @@ See the License for the specific language governing permissions and
     limitations under the License.
     -->
     
    -Geode provides a default result collector. If you need special results handling, code
a custom `ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector`
method to define your custom collector.
    +There is a default result collector. If you need special results handling, code a custom
`ResultsCollector` implementation to replace the provided default. Use the `Execution::withCollector`
method to define your custom collector.
    --- End diff --
    
    Would it be better to make the default results collector more active, e.g., "The default
results collector provides the following functionality..."?


> Geode Native docs: rebrand to match open-source software
> --------------------------------------------------------
>
>                 Key: GEODE-2513
>                 URL: https://issues.apache.org/jira/browse/GEODE-2513
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs
>            Reporter: Dave Barnes
>
> The newly-contributed Geode Native doc sources contain some GemFire artifacts that have
been purged from the open-source code. Docs should be updated to match. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message