geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Re: Review Request 58010: GEODE-2716: export logs default behavior changed from filtering at log level INFO to ALL.
Date Fri, 31 Mar 2017 21:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58010/#review170789
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On March 30, 2017, 7:19 p.m., Patrick Rhomberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58010/
> -----------------------------------------------------------
> 
> (Updated March 30, 2017, 7:19 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund,
and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Added relevant unit and dUnit tests.  Moved default value variable to ExportLogsCommand
and deleted the now-unused LogService.DEFAULT_LOG_LEVEL
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/logging/LogService.java 1f8a564

>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
3f147c1 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
cbdf1c4 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java
95edd42 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionTest.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58010/diff/2/
> 
> 
> Testing
> -------
> 
> precheckin running.
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message