geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken Howe <kh...@pivotal.io>
Subject Re: Review Request 57729: GEODE-2634: use log4j levels for auto-completion
Date Wed, 22 Mar 2017 23:04:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169795
-----------------------------------------------------------



- Ken Howe


On March 17, 2017, 6:48 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57729/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 6:48 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, Kirk Lund, and Patrick
Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> * change the auto complete to use log4j levels.
> * be able to handle both log4j levels and logwriter levels in the commands
> * add validation of log level whenever possible for these commands
> * Move the conversion between the two to a LogLevel class and add unit tests
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/LogWriter.java 242433fb0bd093df1ebbccce388d4b10a510f391

>   geode-core/src/main/java/org/apache/geode/admin/internal/DistributedSystemConfigImpl.java
a89d3904fc999e8a956a06de02b73411987540ee 
>   geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java
decb61d45b7854005b9c5ab554c4e8ead82dcfd9 
>   geode-core/src/main/java/org/apache/geode/i18n/LogWriterI18n.java b9a4df3068f0a3474d9125743e9da0b44e981a5f

>   geode-core/src/main/java/org/apache/geode/internal/admin/remote/RemoteAlert.java 1783e90ecbe2315b8aa496c44cd9fd59e9eb71ba

>   geode-core/src/main/java/org/apache/geode/internal/logging/GemFireLevel.java 0e1dc6ecd97e6132a29044ce29d68769de527336

>   geode-core/src/main/java/org/apache/geode/internal/logging/LogWriterImpl.java 57f0a5cfaf4f975c68be2cc6a1850d5da843259b

>   geode-core/src/main/java/org/apache/geode/internal/logging/log4j/LogLevel.java PRE-CREATION

>   geode-core/src/main/java/org/apache/geode/internal/logging/log4j/LogWriterAppender.java
031a3068d4e188be9f9b7a802f26927f3cacd3f7 
>   geode-core/src/main/java/org/apache/geode/internal/logging/log4j/LogWriterLogger.java
f56599b5490d2dbbacd30a121d135891c67460a4 
>   geode-core/src/main/java/org/apache/geode/management/internal/MemberMessenger.java
25366f9733305e15a65c24c2f24843b54e32c1dd 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java
8c633828f2bb1e110cad98d016e6bf68f866f5e2 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogCommand.java
678fdaf89547326c3743093edea35a264809e64d 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
3ad93ce3b63730f699ae8b7820f277221342adab 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java
1fc60271d70982f83fd078ea36a61bfcedb0c5cc 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/converters/LogLevelConverter.java
39a110c679c43ff192aedcd73a6c68951efffaed 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ChangeLogLevelFunction.java
99f37cc8d2d3941e818eaf1a10b9d888f0e3b342 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunction.java
62026fb749fe220c1dfe16ea2255f8ebfe5958d1 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogLevelExtractor.java
bbeb5c75a73f3749e7a4f62d76533b847f9ce317 
>   geode-core/src/main/java/org/apache/geode/management/internal/cli/util/ReadWriteFile.java
958ed0ec98bb0e3cd3656f914ffe03b16b38e582 
>   geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionConfigJUnitTest.java
080136055feb304ebe6bfe28a0da72e67dfde21f 
>   geode-core/src/test/java/org/apache/geode/internal/logging/log4j/LogLevelTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptorJUnitTest.java
97ed686dcd5a159613f978a4311a44b72b30fefd 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/LogLevelInterceptorTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/converters/LogLevelConverterTest.java
PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/ExportLogsFunctionIntegrationTest.java
cdc57667d5bb06ae904fb04b6b3919a7e879bc7e 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/util/LogLevelExtractorTest.java
fd7d68beeeefd2a26d11f3f971bb089476105e46 
>   geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/CommandOverHttpDUnitTest.java
5f4cd74b8af81ae3bbeff04d6ce44a5c4ac9ec59 
> 
> 
> Diff: https://reviews.apache.org/r/57729/diff/1/
> 
> 
> Testing
> -------
> 
> precheckin successful
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message