geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echobravopapa <...@git.apache.org>
Subject [GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Date Mon, 20 Mar 2017 15:14:38 GMT
Github user echobravopapa commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/63#discussion_r106924902
  
    --- Diff: src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
    @@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client2OpTest)
     
           LOGINFO("FETimeOut begin onServer");
           ExecutionPtr serverExc = FunctionService::onServer(getHelper()->cachePtr);
    -      CacheableVectorPtr vec = serverExc->withArgs(CacheableInt32::create(5000))
    -                                   ->execute(FETimeOut, 5000)
    -                                   ->getResult();
    +      CacheableVectorPtr vec =
    +          serverExc->withArgs(CacheableInt32::create(5000 * 1000))
    --- End diff --
    
    might consider making a constant or two for these literals... in case someone is maintaining
the test later on and needs/wants to adjust times used


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message