geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pivotal-jbarrett <...@git.apache.org>
Subject [GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...
Date Mon, 20 Mar 2017 15:14:06 GMT
Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/63#discussion_r106927339
  
    --- Diff: src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
    @@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1, Client1OpTest2)
           LOGINFO("FETimeOut begin onRegion");
           ExecutionPtr RexecutionPtr = FunctionService::onRegion(regPtr0);
           CacheableVectorPtr fe =
    -          RexecutionPtr->withArgs(CacheableInt32::create(5000))
    +          RexecutionPtr->withArgs(CacheableInt32::create(5000 * 1000))
    --- End diff --
    
    Yes. Ultimately we should consider removing the continuity issue between the client API
and the server. The client is taking the timeout as seconds but sending to the server as milliseconds.
Ultimately taking a chrono::duration would make the API more clear. The test would still need
to be very explicit on the use of milliseconds are the argument to the function.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message