geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PivotalSarge <...@git.apache.org>
Subject [GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...
Date Tue, 07 Mar 2017 20:21:06 GMT
Github user PivotalSarge commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/48#discussion_r104768886
  
    --- Diff: src/cppcache/include/geode/DataOutput.hpp ---
    @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
          */
       inline void writeFullUTF(const char* value, uint32_t length = 0) {
         if (value != NULL) {
    -      int32_t len = getEncodedLength(value, length);
    -      uint16_t encodedLen = static_cast<uint16_t>(len > 0xFFFF ? 0xFFFF : len);
    --- End diff --
    
    If the query string happened to be longer that 0xFFFF, it would be artificially truncated
which often led to errors on the server side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message