geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinmei Liao <jil...@pivotal.io>
Subject Re: Review Request 57242: GEODE-2267: Enhance server/locator startup rules to include workingDir
Date Fri, 03 Mar 2017 00:01:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57242/
-----------------------------------------------------------

(Updated March 3, 2017, 12:01 a.m.)


Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.


Changes
-------

precheckin running


Repository: geode


Description
-------

GEODE-2267: Enhance server/locator startup rules to include workingDir

* This batch is mostly test code change, I am enhancing the ServerStartupRules and LocatorStartupRules
to have a notion of workingDir itself.
* There are only 2 product code change: one is the assembly's build.gradle to correctly set
the gemfire.home/geode.home, another one is to use an absolute path to check for File's exsistance.
Without that, the tests always fail in CI pipeline.


Diffs (updated)
-----

  geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
75a3c2c0996972cab26dc6dad79f675ddfb8f6b3 
  geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
933f7b2ad73b76def7fb1029d4f424f77d1a4211 
  geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseDataExportTest.java fa98ce69559ed5bbdd1eb320734090c3de007106

  geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java 83a367eb88aec85984691e651e5de0f8b479c7cb

  geode-core/src/test/java/org/apache/geode/management/internal/cli/NetstatDUnitTest.java
c6248e052ea8d8579c4f5b2b4de9ec74dca30e72 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfig.java
4ac98864eed9330fce519e4a7054cb8ab6201cae 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java
15e6ea6ec15759800f07e05e8a2bbc6b2d586754 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDistributionDUnitTest.java
e134c42ed88ee7f61e76dcb4503b7ffc13bd2276 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java
72daf0d07feb25a23be84b4a2aae1c1a7668e64c 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java
c0d22bfc697e886cbdb074d9ad5b3241dab93e03 
  geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java
4d67fb0fe4d54299b4b2a523aee0d9126a1e3836 
  geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java
30e1df85da4b6040594ef81bbf9ff5b0dc6f2c31 
  geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java
646819559f608e8262b90e6774f62b2b15b56a82 
  geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java
d1750c3a5efd636c0f9f47fabe670265bf46f072 
  geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java b6d108016f44e3bbafd6c3975d9827a7ac479706

  geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java
5d713f6bf91fcd74e77ba6ed8c1040c605a954ce 
  geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java 12c2da3d000669ea3b28d52bd80d96a17adfa15e

  geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java
092e82b82a8438a3be3394fd997ec727cda5b782 
  geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java f5cfff613300b758b20f3c2acfb875cfa4804d79

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
4729be3f4d9b51168422784a57ac1ec76e018e83 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Locator.java b1004b9cee8c2f2aae96664966aa0e6c7a565fdc

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
39c13d000db80bef37563729bc17ae4bcb566153 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarterRule.java 84c660cfe0ab9b7c6ba0bfc08b034ccaf17697f0

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Member.java 5f46da21f380a67a8e7f4855da1dfbb3118057ba

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberStarterRule.java PRE-CREATION

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/MemberVM.java PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/test/dunit/rules/Server.java 83093c4c8963b64020d7ed8f573e904fccd32e2e

  geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java df3757950c2fd28521958416d763cb1e41ae6456

  geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/configuration/LuceneClusterConfigurationDUnitTest.java
1a344db6be8003fe21bb505362e77a1864e88264 


Diff: https://reviews.apache.org/r/57242/diff/2/

Changes: https://reviews.apache.org/r/57242/diff/1-2/


Testing
-------

precheckin successful


Thanks,

Jinmei Liao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message