geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jared Stewart <jstew...@pivotal.io>
Subject Re: Review Request 57221: GEODE-2541: Fixed ClassCastException failure
Date Wed, 01 Mar 2017 22:11:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167585
-----------------------------------------------------------




geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
Lines 121 (patched)
<https://reviews.apache.org/r/57221/#comment239489>

    I think this cleanup can be moved to an @After method as it happens at the end of each
test:
     ```
      gfsh.terminate();
        cache.close();
        ds.disconnect();
    ```


- Jared Stewart


On March 1, 2017, 9:59 p.m., Ken Howe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57221/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 9:59 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Fixed in HeadlessGfsh, and added new test for handling a command response
> that's not a CommandResult object
> 
> Refactored HeadlessGfshIntegrationTest: removed wildcard imports and extracted common
test setup code
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java
72be0c7fa6839ff7f818cffa4ee5b436bebd2ce8 
>   geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfshIntegrationTest.java
2ea8d9947948810b8e69df83d3a6cf59038d901d 
> 
> 
> Diff: https://reviews.apache.org/r/57221/diff/1/
> 
> 
> Testing
> -------
> 
> Ran spotlessApply
> Precheckin is in progress
> 
> 
> Thanks,
> 
> Ken Howe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message