Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D88B3200C2B for ; Thu, 16 Feb 2017 02:56:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D7090160B70; Thu, 16 Feb 2017 01:56:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2B4B0160B5E for ; Thu, 16 Feb 2017 02:56:07 +0100 (CET) Received: (qmail 53757 invoked by uid 500); 16 Feb 2017 01:56:06 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 53743 invoked by uid 99); 16 Feb 2017 01:56:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 01:56:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D6FA431E78B; Thu, 16 Feb 2017 01:56:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5867412415420054007==" MIME-Version: 1.0 Subject: Review Request 56738: GEODE-2489: Avoid sending tombstone GC messages to peer nodes if there is no client registration From: anilkumar gingade To: Darrel Schneider , Eric Shu Cc: anilkumar gingade , geode Date: Thu, 16 Feb 2017 01:56:04 -0000 Message-ID: <20170216015604.31018.19573@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: anilkumar gingade X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56738/ X-Sender: anilkumar gingade Reply-To: anilkumar gingade X-ReviewRequest-Repository: geode archived-at: Thu, 16 Feb 2017 01:56:08 -0000 --===============5867412415420054007== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56738/ ----------------------------------------------------------- Review request for geode, Darrel Schneider and Eric Shu. Repository: geode Description ------- Tombstone: As part of consistency checking, when an entry is destroyed, the member temporarily retains the entry to detect possible conflicts with operations that have occurred. The retained entry is referred to as a tombstone. When tombstones are removed, tombstone messages are sent to region replicas; and in case of Partitioned Region (PR) messages are also sent to peer region nodes for client events. Currently tombstone messages meant for clients that have all the keys removed are getting sent to peer PR nodes even though no clients are registered on those peers. Based on the number tombstone keys processed (by default 100000) this could be large message sent to peer node which could impact the performance of the system/cluster. Diffs ----- geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 585f4e4 geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java ca682bc geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java fa82560 geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java 0978585 geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java 9780563 Diff: https://reviews.apache.org/r/56738/diff/ Testing ------- Added new test precheckin Thanks, anilkumar gingade --===============5867412415420054007==--