Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96B09200C2B for ; Thu, 16 Feb 2017 01:33:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 952A3160B70; Thu, 16 Feb 2017 00:33:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E00B6160B5E for ; Thu, 16 Feb 2017 01:33:51 +0100 (CET) Received: (qmail 6238 invoked by uid 500); 16 Feb 2017 00:33:51 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 6220 invoked by uid 99); 16 Feb 2017 00:33:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 00:33:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8FB463120A1; Thu, 16 Feb 2017 00:33:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5918273126188586844==" MIME-Version: 1.0 Subject: Re: Review Request 56734: GEODE-2474: refactor code to use SystemUtils to read OS system props From: Jared Stewart To: Kevin Duling , Jinmei Liao , John Blum , Jared Stewart , Ken Howe Cc: Kirk Lund , geode Date: Thu, 16 Feb 2017 00:33:49 -0000 Message-ID: <20170216003349.31018.9952@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jared Stewart X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56734/ X-Sender: Jared Stewart X-ReviewBoard-ShipIt: 1 References: <20170216002345.13056.9353@reviews.apache.org> In-Reply-To: <20170216002345.13056.9353@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jared Stewart X-ReviewRequest-Repository: geode archived-at: Thu, 16 Feb 2017 00:33:52 -0000 --===============5918273126188586844== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56734/#review165788 ----------------------------------------------------------- Ship it! Ship It! - Jared Stewart On Feb. 16, 2017, 12:23 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56734/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 12:23 a.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling, and Ken Howe. > > > Bugs: GEODE-2474 > https://issues.apache.org/jira/browse/GEODE-2474 > > > Repository: geode > > > Description > ------- > > GEODE-2474: refactor code to use SystemUtils to read OS system props > > Centralize OS system property reading in SystemUtils. > > Refactor NetstatFunction and GemFireVersion to use SystemUtils. > > Fix use of netstat and lsof on Mac OS. > > Add TODOs for future cleanup of NetstatFunction. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e > geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 66c158c93fecac4feb2da56f617f5efc7bba56e1 > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java c435e04dc50ccae50c1008d1153797bbc6ff30f4 > geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java 48f176eabc18d3ffa56daaa7da12634a9554f39d > > Diff: https://reviews.apache.org/r/56734/diff/ > > > Testing > ------- > > precheckin passed > > > Thanks, > > Kirk Lund > > --===============5918273126188586844==--