Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AAFCF200C2B for ; Thu, 16 Feb 2017 00:23:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A96C7160B70; Wed, 15 Feb 2017 23:23:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F37B0160B5E for ; Thu, 16 Feb 2017 00:23:05 +0100 (CET) Received: (qmail 79519 invoked by uid 500); 15 Feb 2017 23:23:05 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 79503 invoked by uid 99); 15 Feb 2017 23:23:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Feb 2017 23:23:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B317731083B; Wed, 15 Feb 2017 23:23:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8313969815457342862==" MIME-Version: 1.0 Subject: Re: Review Request 56633: GEODE-2474: refactor code to use SystemUtils to read OS system props From: Kirk Lund To: Kevin Duling , Jinmei Liao , Jared Stewart , Ken Howe Cc: Kirk Lund , geode Date: Wed, 15 Feb 2017 23:23:03 -0000 Message-ID: <20170215232303.31018.15259@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kirk Lund X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56633/ X-Sender: Kirk Lund References: <20170214023135.13057.91176@reviews.apache.org> In-Reply-To: <20170214023135.13057.91176@reviews.apache.org> Reply-To: Kirk Lund X-ReviewRequest-Repository: geode archived-at: Wed, 15 Feb 2017 23:23:06 -0000 --===============8313969815457342862== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56633/ ----------------------------------------------------------- (Updated Feb. 15, 2017, 11:23 p.m.) Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, and Ken Howe. Changes ------- Remove -e for all OS except Windows Bugs: GEODE-2474 https://issues.apache.org/jira/browse/GEODE-2474 Repository: geode Description ------- GEODE-2474: refactor code to use SystemUtils to read OS system props Centralize OS system property reading in SystemUtils. Refactor NetstatFunction and GemFireVersion to use SystemUtils. This fixes use of --with-lsof on Mac (manually tested). I'll add new tests to NetstatDUnitTest and a new integration test for netstat command in a follow-up commit & review. I have several changes on feature/GEODE-2474 branch which I'll separate into multiple reviews. I'll do a final precheckin on the entire branch and then merge the changes in after everything passes review and precheckin. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 66c158c93fecac4feb2da56f617f5efc7bba56e1 geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java 5fa30f47187972a209a781eae9024957dc80fb72 geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java 48f176eabc18d3ffa56daaa7da12634a9554f39d Diff: https://reviews.apache.org/r/56633/diff/ Testing ------- SystemUtilsJUnitTest NetstatDUnitTest Thanks, Kirk Lund --===============8313969815457342862==--