Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 89EBC200C17 for ; Fri, 10 Feb 2017 20:50:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8641F160B5C; Fri, 10 Feb 2017 19:50:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CD458160B4E for ; Fri, 10 Feb 2017 20:50:36 +0100 (CET) Received: (qmail 53014 invoked by uid 500); 10 Feb 2017 19:50:36 -0000 Mailing-List: contact dev-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list dev@geode.apache.org Received: (qmail 52995 invoked by uid 99); 10 Feb 2017 19:50:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 19:50:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BB3E62DF94E; Fri, 10 Feb 2017 19:50:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6967898724642591784==" MIME-Version: 1.0 Subject: Re: Review Request 56522: GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time. From: Jared Stewart To: Kevin Duling , Swapnil Bawaskar , Kirk Lund , Jared Stewart Cc: Jinmei Liao , geode Date: Fri, 10 Feb 2017 19:50:34 -0000 Message-ID: <20170210195034.31774.62593@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jared Stewart X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56522/ In-Reply-To: <20170210005741.31774.76873@reviews.apache.org> X-Sender: Jared Stewart X-ReviewBoard-ShipIt: 1 References: <20170210005741.31774.76873@reviews.apache.org> X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GetRegionNamesFunction.java X-ReviewBoard-Diff-For: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java X-ReviewBoard-ShipIt-Only: 1 Reply-To: Jared Stewart X-ReviewRequest-Repository: geode archived-at: Fri, 10 Feb 2017 19:50:37 -0000 --===============6967898724642591784== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56522/#review165155 ----------------------------------------------------------- Ship it! Ship It! - Jared Stewart On Feb. 10, 2017, 12:57 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56522/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 12:57 a.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, Kirk Lund, and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > GEODE-2198: do not import cluster config if any region exists to prevent different servers having conflicing region definitions at one point of time. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java f822c67b42299d72d740f91795b34693401f6736 > geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/RegionsWithDataOnServerFunction.java c7ec2bb750c67c16fef6634db936a85456a1e6bb > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java b4cba61d871339570dd3ea18f5532ec597736879 > > Diff: https://reviews.apache.org/r/56522/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > > --===============6967898724642591784==--