geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hitesh Khamesra (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (GEODE-1272) IndexManager.populateIndexes(Collection) may deserialize pdx to domain objects
Date Sat, 11 Feb 2017 00:29:41 GMT

     [ https://issues.apache.org/jira/browse/GEODE-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hitesh Khamesra closed GEODE-1272.
----------------------------------

> IndexManager.populateIndexes(Collection) may deserialize pdx to domain objects
> ------------------------------------------------------------------------------
>
>                 Key: GEODE-1272
>                 URL: https://issues.apache.org/jira/browse/GEODE-1272
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Darrel Schneider
>            Assignee: Dan Smith
>             Fix For: 1.1.0
>
>
> Looking at the IndexManager.populateIndexes I see it iterating over all the entries in
a region and adding each entry to each index. What is unclear is if this code correctly calls
DefaultQuery.setPdxReadSerialized before accessing the value from the entry. Please verify
that when this code is used it will not deserialize pdx to domain object.
> Note that the code currently calls RegionEntry.getValue for every entry and I thought
that might be a problem. But since getValue just returns the VMCachedDeserializable and does
not try to deserialize the value it wraps it does not cause a problem. So the only issue would
be what happens each each entry is passed to AbstractIndex.addIndexMapping.
> I looked the callers of IndexManager.populateIndexes and could not find them calling
DefaultQuery.setPdxReadSerialized.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message