geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anilkumar gingade <aging...@pivotal.io>
Subject Review Request 56738: GEODE-2489: Avoid sending tombstone GC messages to peer nodes if there is no client registration
Date Thu, 16 Feb 2017 01:56:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56738/
-----------------------------------------------------------

Review request for geode, Darrel Schneider and Eric Shu.


Repository: geode


Description
-------

Tombstone:
As part of consistency checking, when an entry is destroyed, the member temporarily retains
the entry to detect possible conflicts with operations that have occurred. The retained entry
is referred to as a tombstone.

When tombstones are removed, tombstone messages are sent to region replicas; and in case of
Partitioned Region (PR) messages are also sent to peer region nodes for client events.

Currently tombstone messages meant for clients that have all the keys removed are getting
sent to peer PR nodes even though no clients are registered on those peers.

Based on the number tombstone keys processed (by default 100000) this could be large message
sent to peer node which could impact the performance of the system/cluster.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java 585f4e4 
  geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java ca682bc 
  geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java
fa82560 
  geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java
0978585 
  geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java 9780563


Diff: https://reviews.apache.org/r/56738/diff/


Testing
-------

Added new test
precheckin


Thanks,

anilkumar gingade


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message