geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Re: Review Request 56735: GEODE-2481: extract default properties generation to its own class
Date Thu, 16 Feb 2017 00:36:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56735/
-----------------------------------------------------------

(Updated Feb. 16, 2017, 12:36 a.m.)


Review request for geode, Anthony Baker, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling,
and Dan Smith.


Bugs: GEODE-2481
    https://issues.apache.org/jira/browse/GEODE-2481


Repository: geode


Description (updated)
-------

GEODE-2481: extract default properties generation to its own class

While refactoring GemFireVersion for GEODE-2474, I noticed that GemFireVersionIntegrationJUnitTest
has nothing to do with GemFireVersion.

Extract generation of default properties to DefaultPropertiesGenerator.

Rename GemFireVersionIntegrationJUnitTest to DefaultPropertiesGeneratorIntegrationTest. Add
tests to increase code coverage.

DistributionConfig and DefaultPropertiesGenerator should eventually move to a configuration
package.


Diffs
-----

  geode-assembly/build.gradle f34688043dd3e6bf8e8bdf0cb223d533b692e301 
  geode-core/src/main/java/org/apache/geode/distributed/internal/DefaultPropertiesGenerator.java
PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
fa6d13f7cec40ae18f78da28b3b912e01be363aa 
  geode-core/src/test/java/org/apache/geode/distributed/internal/DefaultPropertiesGeneratorIntegrationTest.java
PRE-CREATION 
  geode-core/src/test/java/org/apache/geode/internal/GemFireVersionIntegrationJUnitTest.java
cae331325f17b470e6dd786d0f9a52bba7cb42a6 

Diff: https://reviews.apache.org/r/56735/diff/


Testing
-------

precheckin passed


Thanks,

Kirk Lund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message