geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kirk.l...@gmail.com>
Subject Review Request 56734: GEODE-2474: refactor code to use SystemUtils to read OS system props
Date Thu, 16 Feb 2017 00:23:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56734/
-----------------------------------------------------------

Review request for geode, Jinmei Liao, Jared Stewart, John Blum, Kevin Duling, and Ken Howe.


Bugs: GEODE-2474
    https://issues.apache.org/jira/browse/GEODE-2474


Repository: geode


Description
-------

GEODE-2474: refactor code to use SystemUtils to read OS system props

Centralize OS system property reading in SystemUtils.

Refactor NetstatFunction and GemFireVersion to use SystemUtils.

Fix use of netstat and lsof on Mac OS.

Add TODOs for future cleanup of NetstatFunction.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/GemFireVersion.java 26d4fb3c5705bffdcdbbc6c261dbe9ffd297642e

  geode-core/src/main/java/org/apache/geode/internal/lang/SystemUtils.java 66c158c93fecac4feb2da56f617f5efc7bba56e1

  geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/NetstatFunction.java
c435e04dc50ccae50c1008d1153797bbc6ff30f4 
  geode-core/src/test/java/org/apache/geode/internal/lang/SystemUtilsJUnitTest.java 48f176eabc18d3ffa56daaa7da12634a9554f39d


Diff: https://reviews.apache.org/r/56734/diff/


Testing
-------

precheckin passed


Thanks,

Kirk Lund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message