geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Huynh <jhu...@pivotal.io>
Subject Re: Review Request 56719: GEODE-2491: Reduce logging of handled exceptions in LuceneEventListener and LuceneBucketListeners
Date Thu, 16 Feb 2017 00:02:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56719/
-----------------------------------------------------------

(Updated Feb. 16, 2017, 12:02 a.m.)


Review request for geode, Lynn Hughes-Godfrey, nabarun nag, and Dan Smith.


Changes
-------

modified exception handling when executing the LuceneFunction.  It will now log as debug level.

Also catching PrimaryBucketException and logging afterPrimary exceptions as info instead of
warning.


Repository: geode


Description
-------

Reduced logging level of specific exceptions from warn level to debug

I can collapse the exceptions into a single catch, wasn't sure if we wanted to log something
different for each type or not...

No longer catching all exceptions when closing the lucene index, instead only handling specific
ones, we can add more if we see others being thrown...


Diffs (updated)
-----

  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneBucketListener.java
0af2719 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventListener.java
44453e4 
  geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java
9d45526 

Diff: https://reviews.apache.org/r/56719/diff/


Testing
-------


Thanks,

Jason Huynh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message