geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anilkumar gingade <aging...@pivotal.io>
Subject Review Request 56729: Avoid processing tombstone GC message in-line.
Date Wed, 15 Feb 2017 22:55:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56729/
-----------------------------------------------------------

Review request for geode.


Repository: geode


Description
-------

Tombstone:
As part of consistency checking, when an entry is destroyed, the member temporarily retains
the entry to detect possible conflicts with operations that have occurred. The retained entry
is referred to as a tombstone.

When tombstones are removed, tombstone messages are sent to region replicas.

Currently the tombstone message sent for replicas are getting processed in-line instead of
handing it to thread pool. Based on the number of nodes in the cluster, this may take long
time to process, impacting other cache operation that required to be processed in-line.

The change provided here enables tombstone messages to be not processed in-line instead processed
in separate thread.


Diffs
-----

  geode-core/src/main/java/org/apache/geode/internal/cache/DistributedTombstoneOperation.java
0765e16 
  geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java 9780563


Diff: https://reviews.apache.org/r/56729/diff/


Testing
-------

New test added.
precheckin.


Thanks,

anilkumar gingade


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message