geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Udo Kohlmeyer <ukohlme...@gmail.com>
Subject Re: Review Request 56564: GEODE-2449: Moved Redis out of Geode-core into its own module
Date Fri, 10 Feb 2017 22:49:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56564/
-----------------------------------------------------------

(Updated Feb. 10, 2017, 10:49 p.m.)


Review request for geode, Bruce Schuchardt, Galen O'Sullivan, Hitesh Khamesra, and Dan Smith.


Changes
-------

updated diff with review changes


Repository: geode


Description
-------

Moved Geode-Redis out of core. No other changes other than code move and some test clean up.
Added GeodeRedisService Interface to be used for the ServiceLoader code in GemFireCacheImpl


Diffs (updated)
-----

  geode-core/build.gradle 8eba6d4e8 
  geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java 63f650510

  geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfigImpl.java
fa6d13f7c 
  geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 6e374ecb7

  geode-core/src/main/java/org/apache/geode/internal/hll/Bits.java 595fb57ac 
  geode-core/src/main/java/org/apache/geode/internal/hll/CardinalityMergeException.java 59ab0950e

  geode-core/src/main/java/org/apache/geode/internal/hll/HyperLogLog.java 4bdf81c77 
  geode-core/src/main/java/org/apache/geode/internal/hll/HyperLogLogPlus.java fc4b6e554 
  geode-core/src/main/java/org/apache/geode/internal/hll/IBuilder.java 10189c8bc 
  geode-core/src/main/java/org/apache/geode/internal/hll/ICardinality.java 125b62183 
  geode-core/src/main/java/org/apache/geode/internal/hll/MurmurHash.java be19e29ae 
  geode-core/src/main/java/org/apache/geode/internal/hll/RegisterSet.java cad691b25 
  geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/FixedPartitionAttributesInfo.java
eb0435a37 
  geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 4c97c98bf 
  geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java PRE-CREATION 
  geode-core/src/main/java/org/apache/geode/redis/internal/ByteArrayWrapper.java 4a0ef5989

  geode-core/src/main/java/org/apache/geode/redis/internal/ByteToCommandDecoder.java 124bf7512

  geode-core/src/main/java/org/apache/geode/redis/internal/Coder.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/Command.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/DoubleWrapper.java 60cd130da 
  geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java e2b49bedc

  geode-core/src/main/java/org/apache/geode/redis/internal/Executor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/Extendable.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/RedisCommandParserException.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/RedisConstants.java 3c39c01c5 
  geode-core/src/main/java/org/apache/geode/redis/internal/RedisDataType.java 63a15dff9 
  geode-core/src/main/java/org/apache/geode/redis/internal/RedisDataTypeMismatchException.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/RegionCreationException.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java 5994d7d8c 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/AbstractExecutor.java
c9d47ab9b 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/AbstractScanExecutor.java
0eb6dcad3 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/AuthExecutor.java 9d318a450

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/DBSizeExecutor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/DelExecutor.java e0db6518c

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/EchoExecutor.java 407e65354

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ExistsExecutor.java 96611dc06

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ExpirationExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ExpireAtExecutor.java
0962a7daa 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ExpireExecutor.java d986826e7

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/FlushAllExecutor.java
f8551665a 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/KeysExecutor.java 9398d87e3

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ListQuery.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/PExpireAtExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/PExpireExecutor.java 

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/PTTLExecutor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/PersistExecutor.java db4d19a88

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/PingExecutor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/QuitExecutor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ScanExecutor.java 5e625cf5d

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/ShutDownExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/SortedSetQuery.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/TTLExecutor.java 530e96a74

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/TimeExecutor.java 6370f94db

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/TypeExecutor.java d97bc0574

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/UnkownExecutor.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HDelExecutor.java
f9f4f19d9 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HExistsExecutor.java
9cd673dbb 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HGetAllExecutor.java
1dbde8182 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HGetExecutor.java
20d2220d4 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HIncrByExecutor.java
695982f4d 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HIncrByFloatExecutor.java
4c7cb3cb2 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HKeysExecutor.java
8d0a6b7dd 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HLenExecutor.java
bcb37f14a 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HMGetExecutor.java
bf1be2b58 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HMSetExecutor.java
a7be53da2 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HScanExecutor.java
bb5c394cd 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HSetExecutor.java
34b3c8a03 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HSetNXExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HValsExecutor.java
1ca8071d6 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/HllExecutor.java 

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/PFAddExecutor.java
8b3b33739 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/PFCountExecutor.java
c550cceb6 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/PFMergeExecutor.java
6d0bb4f92 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/hll/Varint.java  
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LIndexExecutor.java
c80a5050d 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LInsertExecutor.java
ac9f65306 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LLenExecutor.java
f9e685f4c 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LPopExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LPushExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LPushXExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LRangeExecutor.java
fc364086e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LRemExecutor.java
be0793e84 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LSetExecutor.java
0a530412c 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/LTrimExecutor.java
de5804fda 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/ListExecutor.java
ab80a365e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/PopExecutor.java
d5c6e012b 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/PushExecutor.java
b6017a51e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/PushXExecutor.java
3123f92a4 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/RPopExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/RPushExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/list/RPushXExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SAddExecutor.java
2226a55ce 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SCardExecutor.java
c1d3a4c71 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SDiffExecutor.java
ef61a93d5 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SDiffStoreExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SInterExecutor.java
e51fa2c5b 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SInterStoreExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SIsMemberExecutor.java
62ff59723 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMembersExecutor.java
dc9489781 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMoveExecutor.java
493cc12f7 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SPopExecutor.java
e383538fc 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
459402218 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRemExecutor.java
18d46eebd 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SScanExecutor.java
b1a38352a 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SUnionExecutor.java
02e879be0 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SUnionStoreExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SetExecutor.java 

  geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SetOpExecutor.java
7ca72a5f3 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/SortedSetExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZAddExecutor.java
a5bbebc16 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZCardExecutor.java
2294e4eb6 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZCountExecutor.java
72eae68c7 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZIncrByExecutor.java
6c357200f 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZLexCountExecutor.java
42791e22e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByLexExecutor.java
446652126 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeByScoreExecutor.java
454d2810b 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRangeExecutor.java
0058da086 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRankExecutor.java
5fadcaf8d 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRemExecutor.java
5cbc7e4a3 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRemRangeByLexExecutor.java
4bc3554d5 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRemRangeByRankExecutor.java
668a0e424 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRemRangeByScoreExecutor.java
2afd64d03 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRevRangeByScoreExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRevRangeExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZRevRankExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZScanExecutor.java
df0ea4470 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZScoreExecutor.java
158adb3da 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/AppendExecutor.java
7c8c375ff 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/BitCountExecutor.java
68fc35733 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/BitOpExecutor.java
49f0f5c9b 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/BitPosExecutor.java
ca70ae3c3 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/DecrByExecutor.java
6cea0571e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/DecrExecutor.java
fce698b27 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/GetBitExecutor.java
09147b2d4 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/GetExecutor.java
3a529285e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/GetRangeExecutor.java
f80099cbd 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/GetSetExecutor.java
146fff896 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/IncrByExecutor.java
00e2e3b85 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/IncrByFloatExecutor.java
0c20f66e1 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/IncrExecutor.java
f506fe65a 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/MGetExecutor.java
7c9e80872 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/MSetExecutor.java
a98075b45 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/MSetNXExecutor.java
774886fe9 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/PSetEXExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/SetBitExecutor.java
4fb38d13c 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/SetEXExecutor.java
b6eb12d20 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java
e419ab1e0 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/SetNXExecutor.java
3b2d6f81e 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/SetRangeExecutor.java
215aacb97 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StringExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/string/StrlenExecutor.java
8d35279a1 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/DiscardExecutor.java
0743076de 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/ExecExecutor.java
632a79d97 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/MultiExecutor.java
d269d9369 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/TransactionExecutor.java
 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/UnwatchExecutor.java
3de173eab 
  geode-core/src/main/java/org/apache/geode/redis/internal/executor/transactions/WatchExecutor.java
ff6865db7 
  geode-core/src/main/java/org/apache/geode/redis/internal/org/apache/hadoop/fs/GlobPattern.java
 
  geode-core/src/test/java/org/apache/geode/redis/AuthJUnitTest.java e3ebcf7fd 
  geode-core/src/test/java/org/apache/geode/redis/ConcurrentStartTest.java 759ee3563 
  geode-core/src/test/java/org/apache/geode/redis/HashesJUnitTest.java 5a8ce35c6 
  geode-core/src/test/java/org/apache/geode/redis/ListsJUnitTest.java c8e8d0c35 
  geode-core/src/test/java/org/apache/geode/redis/RedisDistDUnitTest.java d6030a9e5 
  geode-core/src/test/java/org/apache/geode/redis/RedisServerTest.java 81e639d16 
  geode-core/src/test/java/org/apache/geode/redis/SetsJUnitTest.java aaa772478 
  geode-core/src/test/java/org/apache/geode/redis/SortedSetsJUnitTest.java 633cb3d24 
  geode-core/src/test/java/org/apache/geode/redis/StringsJunitTest.java 6d11a7177 
  geode-redis/build.gradle PRE-CREATION 
  geode-redis/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService
PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/ConcurrentStartTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/HashesJUnitTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/ListsJUnitTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/RedisServerTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/RedisTestBase.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/SetsJUnitTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/SortedSetsJUnitTest.java PRE-CREATION 
  geode-redis/src/test/java/org/apache/geode/redis/StringsJunitTest.java PRE-CREATION 
  gradle/dependency-versions.properties a0b291e55 
  settings.gradle c0fdb6e4f 

Diff: https://reviews.apache.org/r/56564/diff/


Testing
-------

precheckin - running


Thanks,

Udo Kohlmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message