geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nabarun nag <n...@pivotal.io>
Subject Re: Review Request 56557: GEODE-2459 When node fails while renaming, new primary node resumes and may delete chunks
Date Fri, 10 Feb 2017 19:59:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56557/#review165159
-----------------------------------------------------------




geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java
(line 118)
<https://reviews.apache.org/r/56557/#comment236967>

    Hi Jason, 
    I am not sure but will we ever need to reset this flag back to false. In a situation when
it prevents the chunk from getting deleted when it is recovering from a shutdown during re-name.
    
    Then immediately after sometime, it is hitting this deleteFile call when it is not recovering
from a crash during a rename. - is it suppose to delete the chunks then? will the file.possiblyRename
    still remain true.


- nabarun nag


On Feb. 10, 2017, 7:42 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56557/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 7:42 p.m.)
> 
> 
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Set a possiblyRenamed field and update the file first
> Any recovering node that ends up removing the renamed file should no longer delete it's
chunks
> 
> The testPartialRename should probably be converted to seperate tests, it actually runs
differently in a debugger.  Right now it expects to kill the cache after the duplicate file
has been created.  So the number of operations has to be high enough to get to the putIfAbsent
in the FileSystem.renameFile() method.
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/File.java
f3718a8 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystem.java
78a5b80 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/filesystem/FileSystemJUnitTest.java
b10b32a 
> 
> Diff: https://reviews.apache.org/r/56557/diff/
> 
> 
> Testing
> -------
> 
> geode-lucene:precheckin
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message