geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Galen O'Sullivan <gosulli...@pivotal.io>
Subject Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates
Date Wed, 01 Feb 2017 19:49:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55736/#review163747
-----------------------------------------------------------


Ship it!




Hooray for deleting code!

Ship it!

- Galen O'Sullivan


On Jan. 20, 2017, 4:50 p.m., Udo Kohlmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55736/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 4:50 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> the add fields have the same behavior and identical code. Refactored the code to use
a single method and reduce duplication
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceHelper.java
39d16a57e 
>   geode-core/src/main/java/org/apache/geode/pdx/internal/json/PdxInstanceSortedHelper.java
7f510da15 
>   geode-core/src/test/java/org/apache/geode/pdx/JSONPdxClientServerDUnitTest.java 396eb1d13

> 
> Diff: https://reviews.apache.org/r/55736/diff/
> 
> 
> Testing
> -------
> 
> precheckin - passed
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message