geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Smith <dsm...@pivotal.io>
Subject Re: Review Request 56104: not to create AEQ for acceor
Date Wed, 01 Feb 2017 01:02:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56104/#review163760
-----------------------------------------------------------


Ship it!




Aggg, I'm sorry, I misread the code. You added a new test. This looks good!

- Dan Smith


On Jan. 31, 2017, 10:11 p.m., xiaojian zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56104/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 10:11 p.m.)
> 
> 
> Review request for geode and Dan Smith.
> 
> 
> Bugs: GEODE-2384
>     https://issues.apache.org/jira/browse/GEODE-2384
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Let accessor not to create AEQ, otherwise, if using persistent region, accessor cannot
start due to AEQ has no persistent.
> 
> 
> Diffs
> -----
> 
>   geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
0b6685d 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java 1e965da

>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPROverflowDUnitTest.java
254156f 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPeerPRPersistentDUnitTest.java
PRE-CREATION 
>   geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java
c4081c5 
> 
> Diff: https://reviews.apache.org/r/56104/diff/
> 
> 
> Testing
> -------
> 
> Modified some tests and added persistent test for query. 
> precheckin
> 
> 
> Thanks,
> 
> xiaojian zhou
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message