Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 52D9B200B4B for ; Thu, 7 Jul 2016 01:46:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5168B160A73; Wed, 6 Jul 2016 23:46:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9B69C160A64 for ; Thu, 7 Jul 2016 01:46:48 +0200 (CEST) Received: (qmail 92796 invoked by uid 500); 6 Jul 2016 23:46:47 -0000 Mailing-List: contact dev-help@geode.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.incubator.apache.org Delivered-To: mailing list dev@geode.incubator.apache.org Received: (qmail 92785 invoked by uid 99); 6 Jul 2016 23:46:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2016 23:46:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 785F9CA7EE for ; Wed, 6 Jul 2016 23:46:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.056 X-Spam-Level: X-Spam-Status: No, score=-3.056 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.287] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1tC-HfuHx3Oi for ; Wed, 6 Jul 2016 23:46:45 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 6E57D5FB0A for ; Wed, 6 Jul 2016 23:46:45 +0000 (UTC) Received: (qmail 92766 invoked by uid 99); 6 Jul 2016 23:46:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jul 2016 23:46:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 39FA32B84AD; Wed, 6 Jul 2016 23:46:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8895257069395535778==" MIME-Version: 1.0 Subject: Re: Review Request 49536: refactor TombstoneService and add more info to testTombstones From: Darrel Schneider To: Sai Boorlagadda , Eric Shu Cc: Darrel Schneider , geode Date: Wed, 06 Jul 2016 23:46:43 -0000 Message-ID: <20160706234643.17622.45194@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Darrel Schneider X-ReviewGroup: geode X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/49536/ X-Sender: Darrel Schneider References: <20160706231227.17622.37119@reviews.apache.org> In-Reply-To: <20160706231227.17622.37119@reviews.apache.org> X-ReviewBoard-Diff-For: geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/CacheTime.java Reply-To: Darrel Schneider X-ReviewRequest-Repository: geode archived-at: Wed, 06 Jul 2016 23:46:49 -0000 --===============8895257069395535778== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On July 6, 2016, 4:12 p.m., Sai Boorlagadda wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TombstoneService.java, line 1105 > > > > > > The method does delete while scanning. Should the name be more explicit? Eg: removeUnexpiredIf, removeExpiredIf, removeIf yes! thanks for the new names - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49536/#review141040 ----------------------------------------------------------- On July 1, 2016, 3:13 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49536/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 3:13 p.m.) > > > Review request for geode, Eric Shu and Sai Boorlagadda. > > > Bugs: GEODE-1420 > https://issues.apache.org/jira/browse/GEODE-1420 > > > Repository: geode > > > Description > ------- > > testTombstones has a history of intermittently failing. > I fixed some race conditions in the product and added more information to the assertion message if the test fails again. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/CacheTime.java PRE-CREATION > geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DSClock.java d13610a399242295eb789db08fb165eaee093829 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionEntry.java 6ee4c17d81b1486b0a0c772ba6e0ae7867bb9e4f > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java bc919fc69a46946b8a195fb8fe68a1d11b96d04e > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java e0f6fa285914a0af3897b47ff04e18ef74750cbc > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 186ebbcae83de759809bc881abb0cf5e59623d3d > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/InitialImageOperation.java 55bdde4c6488979a9d790e28f2fbcac53a02255a > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 205f38f9b7829caedd1a29cce8b306942429fac2 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TombstoneService.java 7036d452bd63da63741aa0dcc8e1b66e83073199 > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java c4b48f43cecfc5afc98ffe7636d05a8c8f4adf67 > geode-core/src/test/java/com/gemstone/gemfire/cache30/DistributedAckRegionCCEDUnitTest.java 652bd6bf7c1f52836cd8c496b40376bdd7b7ce6b > geode-core/src/test/java/com/gemstone/gemfire/cache30/GlobalRegionCCEDUnitTest.java 1458e4f1258adaec1e053b2bef2cb4740a7321ec > geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java a8a512eafec7f1b42834c4c83901842dd94af998 > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/GIIDeltaDUnitTest.java c92a436123b9fbe1220658045cc33c846dda3cf6 > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionDelayedRecoveryDUnitTest.java bdadd8a3f229e9b8cbf5401fcc9fd48170eb747d > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TombstoneCreationJUnitTest.java 3eeddf5bcdb2f5e7d3032c88aa9c7467851f4aec > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/persistence/PersistentRVVRecoveryDUnitTest.java f7c011d1301da6ab992838717419f99bd17b8653 > > Diff: https://reviews.apache.org/r/49536/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > > --===============8895257069395535778==--