geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kirk Lund <kl...@pivotal.io>
Subject Re: Build failed in Jenkins: Geode-nightly #520
Date Tue, 05 Jul 2016 16:57:28 GMT
GfshHistoryJUnitTest is now failing after my commit on Friday.

The test expects unrecognized options to cause the command to fail.

Replacing our forked version of jopt-simple with a released version has
caused us to lose the ability to fail any command that contains
unrecognized arguments or unrecognized options. The latter could be
restored but it currently causes incorrect behavior with auto-complete.

I propose changing the test to match the new behavior. My opinion is that
this is a better compromise that breaking auto-complete or spending further
unknown time devising additional workarounds. This is up for discussion so
please weigh in.

-Kirk

On Tuesday, July 5, 2016, Anthony Baker <abaker@pivotal.io> wrote:

> Thanks Jinmei!  Can you share with the list the results of your discussion?
>
> “If it doesn’t happen on the mailing list, it didn’t happen.” [1]
>         —The Apache Way
>
> Anthony
>
> [1] https://community.apache.org/newbiefaq.html
>
> > On Jul 5, 2016, at 8:50 AM, Jinmei Liao <jiliao@pivotal.io
> <javascript:;>> wrote:
> >
> > It has something to do with the 7/1 checkin on gfshParser. I'll talk to
> the
> > team about if they want to revert the changes or fix the test if the
> change
> > is expected.
> >
> > On Tue, Jul 5, 2016 at 8:28 AM, Jinmei Liao <jiliao@pivotal.io
> <javascript:;>> wrote:
> >
> >> I'll take a look.
> >>
> >> On Tue, Jul 5, 2016 at 8:24 AM, Anthony Baker <abaker@pivotal.io
> <javascript:;>> wrote:
> >>
> >>> This test is failing pretty regularly.  Any volunteers to take a look?
> >>>
> >>> Anthony
> >>>
> >>> On Jul 5, 2016, at 7:20 AM, Apache Jenkins Server <
> >>> jenkins@builds.apache.org <javascript:;>> wrote:
> >>>
> >>> geode-core:integrationTest
> >>>
> >>>
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest >
> >>> testHistoryFileIsCreated FAILED
> >>>   org.junit.ComparisonFailure: expected:<[]connect --fake-param...>
but
> >>> was:<[// [failed] ]connect --fake-param...>
> >>>       at org.junit.Assert.assertEquals(Assert.java:115)
> >>>       at org.junit.Assert.assertEquals(Assert.java:144)
> >>>       at
> >>>
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest.testHistoryFileIsCreated(GfshHistoryJUnitTest.java:75)
> >>>
> >>>
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest >
> >>> testHistoryFileDoesNotContainPasswords FAILED
> >>>   org.junit.ComparisonFailure: expected:<[// [failed] ]connect
> >>> --password=*...> but was:<[]connect --password=*...>
> >>>       at org.junit.Assert.assertEquals(Assert.java:115)
> >>>       at org.junit.Assert.assertEquals(Assert.java:144)
> >>>       at
> >>>
> com.gemstone.gemfire.management.internal.cli.shell.GfshHistoryJUnitTest.testHistoryFileDoesNotContainPasswords(GfshHistoryJUnitTest.java:84)
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >> Cheers
> >>
> >> Jinmei
> >>
> >
> >
> >
> > --
> > Cheers
> >
> > Jinmei
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message