geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nabarunnag <>
Subject [GitHub] incubator-geode pull request #190: Feature/geode 11 gfsh commands
Date Thu, 07 Jul 2016 17:56:48 GMT
Github user nabarunnag commented on a diff in the pull request:
    --- Diff: geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/cli/
    @@ -0,0 +1,78 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package com.gemstone.gemfire.cache.lucene.internal.cli;
    +import com.gemstone.gemfire.cache.*;
    +import com.gemstone.gemfire.cache.lucene.LuceneService;
    +import com.gemstone.gemfire.cache.lucene.LuceneServiceProvider;
    +import com.gemstone.gemfire.test.dunit.*;
    +import com.gemstone.gemfire.test.junit.categories.DistributedTest;
    +import org.junit.Test;
    +import org.junit.experimental.categories.Category;
    +import static com.gemstone.gemfire.cache.lucene.test.LuceneTestUtilities.*;
    +import static com.gemstone.gemfire.test.dunit.Assert.*;
    +public class LuceneIndexCommandsDUnitTest extends CliCommandTestBase {
    +  @Test
    +  public void testListIndex() throws Exception {
    --- End diff --
    I am not sure of this one but should we maintain the test naming convention as test<what
is expected><what is test situation or what is passed>()

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message