geode-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anilkumar gingade <aging...@pivotal.io>
Subject Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection
Date Thu, 07 Jul 2016 17:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review141188
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java

<https://reviews.apache.org/r/49102/#comment206609>

    How about adding comment about why we need to proceed even if the processor is stopped...This
will help in future, if someone introduces the stop check back again...


- anilkumar gingade


On July 6, 2016, 8:42 p.m., Jason Huynh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49102/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 8:42 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and
xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> When closing a sender, the close connection message is sent on the same connection that
is used by the ack reader thread.  This causes an issue as two threads are now reading off
the same socket concurrently.  The fix is to prevent this from happening but to do so, the
input stream needs to be closed (to free up from a socket read()).  
> The dispatcher also needs to shut down before the close connection is sent out or it
will spawn off another ack reader thread.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
ce08e8d 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
07a3be5 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
ff810ec 
>   geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
b178192 
>   geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 358ffaf

> 
> Diff: https://reviews.apache.org/r/49102/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message